Improve harvesting #178

Merged

import_user_oitsjustjose_95mQ merged 3 commits from github/fork/pau101/improve-harvesting into 1.14.4

2019-10-16 18:27:42 +00:00

import_user_oitsjustjose_95mQ commented

2019-10-16 18:09:52 +00:00

(Migrated from git.oitsjustjose.com)

I saw your tweet about needing all this code to make server side arm swing so I set out for this pr to be simplifying that like so:

player.swingArm(Hand.MAIN_HAND);
((ServerPlayerEntity) player).connection.sendPacket(new SAnimateHandPacket(player, 0));

However the delay between swing and block change was too much for this convey a good cause and effect so I made the swing occur on both sides. Then while looking at this code I couldn't help but just reduce it all around and make it more robust so I did that too.

I saw your tweet about needing all this code to make server side arm swing so I set out for this pr to be simplifying that like so: ```java player.swingArm(Hand.MAIN_HAND); ((ServerPlayerEntity) player).connection.sendPacket(new SAnimateHandPacket(player, 0)); ``` However the delay between swing and block change was too much for this convey a good cause and effect so I made the swing occur on both sides. Then while looking at this code I couldn't help but just reduce it all around and make it more robust so I did that too.

import_user_oitsjustjose_95mQ commented

2019-10-16 18:27:42 +00:00

(Migrated from git.oitsjustjose.com)

Wow, this is great! I looked through the PR and I really like how much easier (and more extensible) it is. This is what I get for almost verbatim porting the code instead of seeking better alternatives.

Thanks for the help!!

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this pull request

2019-10-16 18:27:42 +00:00

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) merged commit into 1.14.4

2019-10-16 18:27:42 +00:00