oitsjustjose/V-Tweaks
Watch
1
0
Fork
You've already forked V-Tweaks
 0
Code Issues 6 Pull requests Projects Releases 2 Packages Activity Actions

Don't remove me unless you do something with me! #161

Merged
import_user_oitsjustjose_95mQ merged 1 commit from github/fork/thiakil/patch-1 into 1.12 2017-08-26 04:11:30 +00:00
Conversation 6 Commits 1 Files changed 1 +1 -1
import_user_oitsjustjose_95mQ commented 2017-08-26 04:10:10 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

Maybe will fix the thing

Maybe will fix the thing
import_user_oitsjustjose_95mQ commented 2017-08-26 04:11:24 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

approved this merge request

approved this merge request
import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this pull request 2017-08-26 04:11:30 +00:00
import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) merged commit into 1.12 2017-08-26 04:11:30 +00:00
import_user_oitsjustjose_95mQ commented 2017-08-26 04:11:53 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

Prolly. Thanks for noticing. I've done so much with V-Tweaks that I can't remember.

Prolly. Thanks for noticing. I've done so much with V-Tweaks that I can't remember.
import_user_oitsjustjose_95mQ commented 2017-08-27 03:52:43 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

I thought further about this and it probably causes a dupe bug. whoops.

Instead maybe you should abort if the the player is instanceof FakePlayer

I thought further about this and it probably causes a dupe bug. whoops. Instead maybe you should abort if the the player is `instanceof FakePlayer`
import_user_oitsjustjose_95mQ commented 2017-08-27 04:02:40 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

How do you theorize it’d create a dupe bug?

How do you theorize it’d create a dupe bug?
import_user_oitsjustjose_95mQ commented 2017-08-27 04:04:55 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

i moved the iterator remove to only do it if it cant add to player inv, so if it can it will add it and it will still be spawned via normal methods

i moved the iterator remove to only do it if it *cant* add to player inv, so if it *can* it will add it and it will still be spawned via normal methods
import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) approved these changes 2026-10-03 02:52:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
import_user_oitsjustjose_95mQ
Labels
Clear labels   
1.12.x

   
1.14.x

   
Bug

   
Can't Fix

   
Can't Reproduce

   
Enhancement

   
Inter-Mod

   
Need Info

   
Won't Fix
No labels
1.12.x
1.14.x
Bug
Can't Fix
Can't Reproduce
Enhancement
Inter-Mod
Need Info
Won't Fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
oitsjustjose/V-Tweaks!161
No description provided.