Data improvements

import_user_oitsjustjose_95mQ commented

2020-05-05 06:55:53 +00:00

(Migrated from git.oitsjustjose.com)

Fix some of my compat recipes which had the wrong tool assigned
Fix disabled advancements failing to parse due to invalid parent "notfound" to clear some errors in the log. A null parent is valid afaik, and the log no longer complains.
Override original plank recipes by placing the sawing plank recipes in the same path as the original. This fixes #23 but removes the config option that removes plank recipes, Users who want them back for some reason can use commands to swap the data pack order or just apply another data pack on top.
Replace the preexisting generate.py with a rewritten version that I used to generate all the recipes
Bump forge version since the previous version was broken on Linux

* Fix some of my compat recipes which had the wrong tool assigned * Fix disabled advancements failing to parse due to invalid parent "notfound" to clear some errors in the log. A null parent is valid afaik, and the log no longer complains. * Override original plank recipes by placing the sawing plank recipes in the same path as the original. This fixes #23 but removes the config option that removes plank recipes, Users who want them back for some reason can use commands to swap the data pack order or just apply another data pack on top. * Replace the preexisting generate.py with a rewritten version that I used to generate all the recipes * Bump forge version since the previous version was broken on Linux

import_user_oitsjustjose_95mQ commented

2020-05-05 09:26:59 +00:00

(Migrated from git.oitsjustjose.com)

changed title from {-[Draft] -}Data improvements to Data improvements

changed title from **{-[Draft] -}Data improvements** to **Data improvements**

import_user_oitsjustjose_95mQ commented

2020-05-05 09:31:51 +00:00

(Migrated from git.oitsjustjose.com)

The one thing here that hasn't been considered yet is load order. The mod's data pack needs to be on top of all others for compat recipes to override correctly. Is there some way to ensure that?

import_user_oitsjustjose_95mQ commented

2020-05-07 08:39:48 +00:00

(Migrated from git.oitsjustjose.com)

One solution for the above issue would be to simply distribute the compat data as a separate data pack, and only include the vanilla plank data with the mod.

import_user_oitsjustjose_95mQ commented

2020-05-27 14:59:04 +00:00

(Migrated from git.oitsjustjose.com)

Sorry, I've been pretty busy with work and moving to a new place but I'll be working on a proper solution for this very soon :)

import_user_oitsjustjose_95mQ commented

2020-12-12 03:07:18 +00:00

(Migrated from git.oitsjustjose.com)

Looks like this won't be merged, so closing to get this out of my queue

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this pull request

2020-12-12 03:07:18 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Rows
Columns

Data improvements #127

Pull request closed