remove forge conditional recipe type #646

Merged

import_user_oitsjustjose_95mQ merged 1 commit from github/fork/rlnt/recipe-conditions into 1.18

2022-08-23 18:58:46 +00:00

import_user_oitsjustjose_95mQ commented

2022-08-23 18:38:24 +00:00

(Migrated from git.oitsjustjose.com)

The forge conditional recipe type is a pain to work with when writing mods that integrate with other mods or JSON recipes.

Since you don't define multiple recipes inside a JSON file, there is no need to use this recipe type. Instead, you can use the conditions property inside a recipe JSON.

I tested the new recipes with and without Immersive Engineering. No errors and no warnings about the recipes and they still load fine when IE is loaded.
Please consider merging this and use the same format for future recipes as this make cross mod compatibility a lot easier.

The forge conditional recipe type is a pain to work with when writing mods that integrate with other mods or JSON recipes. Since you don't define multiple recipes inside a JSON file, there is no need to use this recipe type. Instead, you can use the `conditions` property inside a recipe JSON. I tested the new recipes with and without Immersive Engineering. No errors and no warnings about the recipes and they still load fine when IE is loaded. Please consider merging this and use the same format for future recipes as this make cross mod compatibility a lot easier.

import_user_oitsjustjose_95mQ commented

2022-08-23 18:58:43 +00:00

(Migrated from git.oitsjustjose.com)

Ah, thanks! This facet of Forge's conditional system isn't well documented, the only thing I ever can find on the readthedocs is the method I was using before.

Thank you for these changes!!

Ah, thanks! This facet of Forge's conditional system isn't well documented, the only thing I ever can find on the `readthedocs` is the method I was using before. Thank you for these changes!!

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this pull request

2022-08-23 18:58:46 +00:00

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) merged commit into 1.18

2022-08-23 18:58:46 +00:00