Properly replace ore blocks in vein structures #641

Merged

import_user_oitsjustjose_95mQ merged 2 commits from github/fork/akkad-abraham/1.18 into 1.18 2022-06-05 02:56:54 +00:00

Conversation 4 Commits 2 Files changed 3 +75 -38

import_user_oitsjustjose_95mQ commented 2022-06-05 01:06:12 +00:00 (Migrated from git.oitsjustjose.com)

Copy link

Fixes #310

This pull request fixes the current issue with ore replacement in vanilla veins. Where with the current approach all vanilla ore blocks that are associated with veins - namely: copper and iron and their raw block variants - are bluntly replaced with tuff. As an alternative solution in this PR; The ores are replaced by default by stone or deepslate according to their vein type.

Furthermore, a new config option was introduced removeVeinOres that (when set to false) enables the replacement of vanilla ores in veins with geolosys equivalents so that the veins can optionally keep there intended function.

- Notice: Malachite ore replacing vanilla copper ores in copper veins

- Notice: Deepslate hematite ore replacing iron deepslate ores in iron veins

Fixes #310 This pull request fixes the current issue with ore replacement in vanilla veins. Where with the current approach all vanilla ore blocks that are associated with veins - namely: copper and iron and their raw block variants - are bluntly replaced with tuff. As an alternative solution in this PR; The ores are replaced by default by stone or deepslate according to their vein type. Furthermore, a new config option was introduced `removeVeinOres` that (when set to `false`) enables the replacement of vanilla ores in veins with geolosys equivalents so that the veins can optionally keep there intended function.  _- Notice: Malachite ore replacing vanilla copper ores in copper veins_  _- Notice: Deepslate hematite ore replacing iron deepslate ores in iron veins_

import_user_oitsjustjose_95mQ commented 2022-06-05 01:07:22 +00:00 (Migrated from git.oitsjustjose.com)

Copy link

changed title from {-1.18-} to {+Properly replace ore blocks in vein structures+}

changed title from **{-1.18-}** to **{+Properly replace ore blocks in vein structures+}**

import_user_oitsjustjose_95mQ commented 2022-06-05 02:56:43 +00:00 (Migrated from git.oitsjustjose.com)

Copy link

approved this merge request

approved this merge request

import_user_oitsjustjose_95mQ commented 2022-06-05 02:56:51 +00:00 (Migrated from git.oitsjustjose.com)

Copy link

This looks great! Thanks a ton!

This looks great! Thanks a ton!

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this pull request 2022-06-05 02:56:54 +00:00

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) merged commit into 1.18 2022-06-05 02:56:54 +00:00

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) approved these changes 2026-10-03 02:55:24 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

import_user_oitsjustjose_95mQ

Labels

Clear labels   

bug

  

can't replicate

  

enhancement

  

help wanted

  

inter-mod

  

invalid

  

invasive

  

investigating

  

optimization

No labels

bug

can't replicate

enhancement

help wanted

inter-mod

invalid

invasive

investigating

optimization

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

oitsjustjose/Geolosys!641

No description provided.