Auto-repair condition for daytime can never occur after the first day #16

New issue

Closed

opened 2017-09-20 16:21:38 +00:00 by import_user_oitsjustjose_95mQ · 2 comments

import_user_oitsjustjose_95mQ commented

2017-09-20 16:21:38 +00:00

(Migrated from git.oitsjustjose.com)

Over here:

http://git.oitsjustjose.com/oitsjustjose/TiCon-Addons/-/blob/master/src/main/java/com/oitsjustjose/tinkers_addons/modifiers/ModAutoRepair.java#L94

you check world.getWorldTime(), which is the absolute time since the world started (so it also effectively encodes the moon phase and what often gets used as a basis for 'date' in some mods). It needs to be % 24000 in order to get the time value within a given day.

While I'm here, is it actually intended that your auto-repair works fastest in the nether?

Over here: http://git.oitsjustjose.com/oitsjustjose/TiCon-Addons/-/blob/master/src/main/java/com/oitsjustjose/tinkers_addons/modifiers/ModAutoRepair.java#L94 you check world.getWorldTime(), which is the absolute time since the world started (so it also effectively encodes the moon phase and what often gets used as a basis for 'date' in some mods). It needs to be % 24000 in order to get the time value within a given day. While I'm here, is it actually intended that your auto-repair works fastest in the nether?

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this issue

2017-09-20 16:52:56 +00:00

import_user_oitsjustjose_95mQ commented

2017-09-20 16:54:27 +00:00

(Migrated from git.oitsjustjose.com)

Thanks, fixed :D

Also yes, it is intended; that's how it worked in TiCon 1. I don't know why, but I wanted to keep relatively original.

¯_(ツ)_/¯

Thanks, fixed :D Also yes, it is intended; that's how it worked in TiCon 1. I don't know why, but I wanted to keep relatively original. ¯\_(ツ)_/¯

import_user_oitsjustjose_95mQ commented

2017-09-20 17:11:24 +00:00

(Migrated from git.oitsjustjose.com)