oitsjustjose/Geolosys
Watch
1
0
Fork
You've already forked Geolosys
 0
Code Issues 11 Pull requests Projects Releases Packages Activity Actions 1

Geolosys Ore Gen Funstuff #87

New issue
Closed
opened 2018-03-28 21:23:38 +00:00 by import_user_oitsjustjose_95mQ · 2 comments
import_user_oitsjustjose_95mQ commented 2018-03-28 21:23:38 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

See this

Likely fix: rewriting / refactoring generation code

See [this](https://github.com/Darkosto/SevTech-Ages/issues/1026) Likely fix: rewriting / refactoring generation code
import_user_oitsjustjose_95mQ commented 2018-03-30 19:51:26 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

I'm just looking at the source and don't have a way to test, but it looks like it is related to this line:
git.oitsjustjose.com/oitsjustjose/Geolosys/-@c41a249836/src/main/java/com/oitsjustjose/geolosys/world/OreGenerator.java (L45)

It looks like that is effectively attempting to generate 1 random ore for every chunk.

With a large enough sample size should result in 1 / oreSpawnList.size() possible chunks for every ore, and then the number that actually have ore will be further reduced by the configured weight for each ore.

I'm just looking at the source and don't have a way to test, but it looks like it is related to this line: http://git.oitsjustjose.com/oitsjustjose/Geolosys/-/blob/c41a24983667dcc764a9b8b4af4cbffa22ec6ff3/src/main/java/com/oitsjustjose/geolosys/world/OreGenerator.java#L45 It looks like that is effectively attempting to generate 1 random ore for every chunk. With a large enough sample size should result in 1 / oreSpawnList.size() possible chunks for every ore, and then the number that actually have ore will be further reduced by the configured weight for each ore.
import_user_oitsjustjose_95mQ commented 2018-03-30 21:00:36 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

I’m actually happy with it behavior as of 1.8.10. Thanks though!!

I’m actually happy with it behavior as of 1.8.10. Thanks though!!
import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this issue 2018-03-30 21:00:36 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
1.20.1
1.21.1
1.12.x
1.18
1.19
1.16
1.15
1.14.x
1.12.x-UBC
No results found.
Labels
Clear labels   
bug

   
can't replicate

   
enhancement

   
help wanted

   
inter-mod

   
invalid

   
invasive

   
investigating

   
optimization
No labels
bug
can't replicate
enhancement
help wanted
inter-mod
invalid
invasive
investigating
optimization
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
oitsjustjose/Geolosys#87
No description provided.