Custom Block Breaking Logic Breaks VeinMining Logic? #263

Closed
opened 2021-02-28 13:38:37 +00:00 by import_user_oitsjustjose_95mQ · 2 comments
import_user_oitsjustjose_95mQ commented 2021-02-28 13:38:37 +00:00 (Migrated from git.oitsjustjose.com)

Attempting to veinmine blocks like Platinum while the Osmium feature is enabled breaks the functionality of Veinimining tools somehow.

It's likely the following block:

git.oitsjustjose.com/oitsjustjose/Geolosys/-@b280e2f02a/src/main/java/com/oitsjustjose/geolosys/common/compat/CompatLoader.java (L33-L35)

setBlockState should be replaced with destroyBlock with the drops option set to false. Or just don't cancel the event but clear the drops somehow?

Attempting to veinmine blocks like Platinum while the Osmium feature is enabled breaks the functionality of Veinimining tools somehow. It's likely the following block: http://git.oitsjustjose.com/oitsjustjose/Geolosys/-/blob/b280e2f02a119a875c8e3727769ce672917698a8/src/main/java/com/oitsjustjose/geolosys/common/compat/CompatLoader.java#L33-L35 `setBlockState` should be replaced with `destroyBlock` with the drops option set to false. Or just don't cancel the event but clear the drops somehow?
import_user_oitsjustjose_95mQ commented 2021-02-28 13:38:37 +00:00 (Migrated from git.oitsjustjose.com)

assigned to @oitsjustjose

assigned to `@oitsjustjose`
import_user_oitsjustjose_95mQ commented 2021-03-12 04:49:21 +00:00 (Migrated from git.oitsjustjose.com)

Fixed with Global Loot Modifiers (or it damn well better be??)

Fixed with Global Loot Modifiers (or it damn well better be??)
import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this issue 2021-03-12 04:49:23 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
oitsjustjose/Geolosys#263
No description provided.