oitsjustjose/Geolosys
Watch
1
0
Fork
You've already forked Geolosys
 0
Code Issues 11 Pull requests Projects Releases Packages Activity Actions 1

Huge Memory Usage #245

New issue
Closed
opened 2020-07-04 14:23:15 +00:00 by import_user_oitsjustjose_95mQ · 4 comments
import_user_oitsjustjose_95mQ commented 2020-07-04 14:23:15 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

The loading of the ToDoBlocks is using an insane amount of memory causing the server to run out memory.
Would be great if this can be improved and limited.

git.oitsjustjose.com/oitsjustjose/Geolosys/-@9b26af29e3/src/main/java/com/oitsjustjose/geolosys/common/world/ToDoBlocks.java (L34)


[15:29:53] [Thread Locksmith Watchdog/INFO]: [DedicatedServer]: -#-#-#- START THREAD LOCKSMITH -#-#-#-
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: --- Thread 44 ---
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: Name: Server thread
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: Status: RUNNABLE
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: Stacktrace:
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - java.io.DataInputStream.readUnsignedShort(DataInputStream.java:337)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - java.io.DataInputStream.readUTF(DataInputStream.java:589)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - java.io.DataInputStream.readUTF(DataInputStream.java:564)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.NBTTagCompound.func_152448_b(NBTTagCompound.java:487)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.NBTTagCompound.func_152446_a(NBTTagCompound.java:56)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.NBTTagCompound.func_152449_a(NBTTagCompound.java:497)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.NBTTagCompound.func_152446_a(NBTTagCompound.java:58)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.NBTTagList.func_152446_a(NBTTagList.java:63)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.NBTTagCompound.func_152449_a(NBTTagCompound.java:497)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.NBTTagCompound.func_152446_a(NBTTagCompound.java:58)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.NBTTagCompound.func_152449_a(NBTTagCompound.java:497)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.NBTTagCompound.func_152446_a(NBTTagCompound.java:58)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.CompressedStreamTools.func_152455_a(CompressedStreamTools.java:133)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.CompressedStreamTools.func_152456_a(CompressedStreamTools.java:88)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.nbt.CompressedStreamTools.func_74796_a(CompressedStreamTools.java:31)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.world.storage.MapStorage.func_75742_a(SourceFile:49)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.world.World.func_72943_a(World.java:3677)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - com.oitsjustjose.geolosys.common.world.ToDoBlocks.getForWorld(ToDoBlocks.java:33)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - com.oitsjustjose.geolosys.common.world.StoneGenerator.generate(StoneGenerator.java:46)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraftforge.fml.common.registry.GameRegistry.redirect$forgeImpl$startTimingOnGenerate$zzd000(GameRegistry.java:574)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:167)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - micdoodle8.mods.galacticraft.core.TransformerHooks.otherModGenerate(TransformerHooks.java:198)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.world.chunk.Chunk.func_186034_a(Chunk.java:1020)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.world.chunk.Chunk.func_186030_a(Chunk.java:999)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraftforge.common.chunkio.ChunkIOProvider.syncCallback(ChunkIOProvider.java:110)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraftforge.common.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:150)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:728)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]:  - java.lang.Thread.run(Thread.java:748)
[15:29:53] [Thread Locksmith Watchdog/INFO]: [DedicatedServer]: -#-#-#- END THREAD LOCKSMITH -#-#-#-

Server thread
  at com.google.common.collect.ImmutableSortedMap.get(Ljava/lang/Object;)Ljava/lang/Object; (ImmutableSortedMap.java:601)
  at net.minecraft.block.state.BlockStateContainer.func_185920_a(Ljava/lang/String;)Lnet/minecraft/block/properties/IProperty; (BlockStateContainer.java:168)
  at net.minecraft.nbt.NBTUtil.func_190008_d(Lnet/minecraft/nbt/NBTTagCompound;)Lnet/minecraft/block/state/IBlockState; (SourceFile:194)
  at com.oitsjustjose.geolosys.common.world.ToDoBlocks.func_76184_a(Lnet/minecraft/nbt/NBTTagCompound;)V (ToDoBlocks.java:99)
  at net.minecraft.world.storage.MapStorage.func_75742_a(Ljava/lang/Class;Ljava/lang/String;)Lnet/minecraft/world/storage/WorldSavedData; (SourceFile:52)
  at net.minecraft.world.World.func_72943_a(Ljava/lang/Class;Ljava/lang/String;)Lnet/minecraft/world/storage/WorldSavedData; (World.java:3677)
  at com.oitsjustjose.geolosys.common.world.ToDoBlocks.getForWorld(Lnet/minecraft/world/World;Ljava/lang/String;)Lcom/oitsjustjose/geolosys/common/world/ToDoBlocks; (ToDoBlocks.java:33)
  at com.oitsjustjose.geolosys.common.world.StoneGenerator.generate(Ljava/util/Random;IILnet/minecraft/world/World;Lnet/minecraft/world/gen/IChunkGenerator;Lnet/minecraft/world/chunk/IChunkProvider;)V (StoneGenerator.java:46)
  at net.minecraftforge.fml.common.registry.GameRegistry.redirect$forgeImpl$startTimingOnGenerate$zzd000(Lnet/minecraftforge/fml/common/IWorldGenerator;Ljava/util/Random;IILnet/minecraft/world/World;Lnet/minecraft/world/gen/IChunkGenerator;Lnet/minecraft/world/chunk/IChunkProvider;)V (GameRegistry.java:574)
  at net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(IILnet/minecraft/world/World;Lnet/minecraft/world/gen/IChunkGenerator;Lnet/minecraft/world/chunk/IChunkProvider;)V (GameRegistry.java:167)
  at micdoodle8.mods.galacticraft.core.TransformerHooks.otherModGenerate(IILnet/minecraft/world/World;Lnet/minecraft/world/gen/IChunkGenerator;Lnet/minecraft/world/chunk/IChunkProvider;)V (TransformerHooks.java:198)
  at net.minecraft.world.chunk.Chunk.func_186034_a(Lnet/minecraft/world/gen/IChunkGenerator;)V (Chunk.java:1020)
  at net.minecraft.world.chunk.Chunk.func_186030_a(Lnet/minecraft/world/chunk/IChunkProvider;Lnet/minecraft/world/gen/IChunkGenerator;)V (Chunk.java:999)
  at net.minecraftforge.common.chunkio.ChunkIOProvider.syncCallback()V (ChunkIOProvider.java:110)
  at net.minecraftforge.common.chunkio.ChunkIOExecutor.tick()V (ChunkIOExecutor.java:150)
  at net.minecraft.server.MinecraftServer.func_71190_q()V (MinecraftServer.java:728)
  at net.minecraft.server.dedicated.DedicatedServer.func_71190_q()V (DedicatedServer.java:397)
  at net.minecraft.server.MinecraftServer.func_71217_p()V (MinecraftServer.java:668)
  at net.minecraft.server.MinecraftServer.run()V (MinecraftServer.java:526)
  at java.lang.Thread.run()V (Thread.java:748)

Versions

Forge Version: forge-1.12.2-14.23.5.2838-universal

Mod Version: Geolosys-1.12.2-2.2.6

Other Mods

https://www.curseforge.com/minecraft/modpacks/sevtech-ages/relations/dependencies

The loading of the ToDoBlocks is using an insane amount of memory causing the server to run out memory. Would be great if this can be improved and limited. http://git.oitsjustjose.com/oitsjustjose/Geolosys/-/blob/9b26af29e3d89ed57fc2b875f43defb5faff2a5f/src/main/java/com/oitsjustjose/geolosys/common/world/ToDoBlocks.java#L34 ![](https://i.imgur.com/j5Zc94s.png) ![](https://i.imgur.com/WiZe6X0.png) ``` [15:29:53] [Thread Locksmith Watchdog/INFO]: [DedicatedServer]: -#-#-#- START THREAD LOCKSMITH -#-#-#- [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: --- Thread 44 --- [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: Name: Server thread [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: Status: RUNNABLE [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: Stacktrace: [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - java.io.DataInputStream.readUnsignedShort(DataInputStream.java:337) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - java.io.DataInputStream.readUTF(DataInputStream.java:589) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - java.io.DataInputStream.readUTF(DataInputStream.java:564) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.NBTTagCompound.func_152448_b(NBTTagCompound.java:487) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.NBTTagCompound.func_152446_a(NBTTagCompound.java:56) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.NBTTagCompound.func_152449_a(NBTTagCompound.java:497) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.NBTTagCompound.func_152446_a(NBTTagCompound.java:58) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.NBTTagList.func_152446_a(NBTTagList.java:63) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.NBTTagCompound.func_152449_a(NBTTagCompound.java:497) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.NBTTagCompound.func_152446_a(NBTTagCompound.java:58) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.NBTTagCompound.func_152449_a(NBTTagCompound.java:497) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.NBTTagCompound.func_152446_a(NBTTagCompound.java:58) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.CompressedStreamTools.func_152455_a(CompressedStreamTools.java:133) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.CompressedStreamTools.func_152456_a(CompressedStreamTools.java:88) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.nbt.CompressedStreamTools.func_74796_a(CompressedStreamTools.java:31) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.world.storage.MapStorage.func_75742_a(SourceFile:49) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.world.World.func_72943_a(World.java:3677) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - com.oitsjustjose.geolosys.common.world.ToDoBlocks.getForWorld(ToDoBlocks.java:33) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - com.oitsjustjose.geolosys.common.world.StoneGenerator.generate(StoneGenerator.java:46) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraftforge.fml.common.registry.GameRegistry.redirect$forgeImpl$startTimingOnGenerate$zzd000(GameRegistry.java:574) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:167) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - micdoodle8.mods.galacticraft.core.TransformerHooks.otherModGenerate(TransformerHooks.java:198) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.world.chunk.Chunk.func_186034_a(Chunk.java:1020) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.world.chunk.Chunk.func_186030_a(Chunk.java:999) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraftforge.common.chunkio.ChunkIOProvider.syncCallback(ChunkIOProvider.java:110) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraftforge.common.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:150) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:728) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:397) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [15:29:53] [Thread Locksmith Watchdog/INFO]: [threadlock]: - java.lang.Thread.run(Thread.java:748) [15:29:53] [Thread Locksmith Watchdog/INFO]: [DedicatedServer]: -#-#-#- END THREAD LOCKSMITH -#-#-#- ``` ``` Server thread at com.google.common.collect.ImmutableSortedMap.get(Ljava/lang/Object;)Ljava/lang/Object; (ImmutableSortedMap.java:601) at net.minecraft.block.state.BlockStateContainer.func_185920_a(Ljava/lang/String;)Lnet/minecraft/block/properties/IProperty; (BlockStateContainer.java:168) at net.minecraft.nbt.NBTUtil.func_190008_d(Lnet/minecraft/nbt/NBTTagCompound;)Lnet/minecraft/block/state/IBlockState; (SourceFile:194) at com.oitsjustjose.geolosys.common.world.ToDoBlocks.func_76184_a(Lnet/minecraft/nbt/NBTTagCompound;)V (ToDoBlocks.java:99) at net.minecraft.world.storage.MapStorage.func_75742_a(Ljava/lang/Class;Ljava/lang/String;)Lnet/minecraft/world/storage/WorldSavedData; (SourceFile:52) at net.minecraft.world.World.func_72943_a(Ljava/lang/Class;Ljava/lang/String;)Lnet/minecraft/world/storage/WorldSavedData; (World.java:3677) at com.oitsjustjose.geolosys.common.world.ToDoBlocks.getForWorld(Lnet/minecraft/world/World;Ljava/lang/String;)Lcom/oitsjustjose/geolosys/common/world/ToDoBlocks; (ToDoBlocks.java:33) at com.oitsjustjose.geolosys.common.world.StoneGenerator.generate(Ljava/util/Random;IILnet/minecraft/world/World;Lnet/minecraft/world/gen/IChunkGenerator;Lnet/minecraft/world/chunk/IChunkProvider;)V (StoneGenerator.java:46) at net.minecraftforge.fml.common.registry.GameRegistry.redirect$forgeImpl$startTimingOnGenerate$zzd000(Lnet/minecraftforge/fml/common/IWorldGenerator;Ljava/util/Random;IILnet/minecraft/world/World;Lnet/minecraft/world/gen/IChunkGenerator;Lnet/minecraft/world/chunk/IChunkProvider;)V (GameRegistry.java:574) at net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(IILnet/minecraft/world/World;Lnet/minecraft/world/gen/IChunkGenerator;Lnet/minecraft/world/chunk/IChunkProvider;)V (GameRegistry.java:167) at micdoodle8.mods.galacticraft.core.TransformerHooks.otherModGenerate(IILnet/minecraft/world/World;Lnet/minecraft/world/gen/IChunkGenerator;Lnet/minecraft/world/chunk/IChunkProvider;)V (TransformerHooks.java:198) at net.minecraft.world.chunk.Chunk.func_186034_a(Lnet/minecraft/world/gen/IChunkGenerator;)V (Chunk.java:1020) at net.minecraft.world.chunk.Chunk.func_186030_a(Lnet/minecraft/world/chunk/IChunkProvider;Lnet/minecraft/world/gen/IChunkGenerator;)V (Chunk.java:999) at net.minecraftforge.common.chunkio.ChunkIOProvider.syncCallback()V (ChunkIOProvider.java:110) at net.minecraftforge.common.chunkio.ChunkIOExecutor.tick()V (ChunkIOExecutor.java:150) at net.minecraft.server.MinecraftServer.func_71190_q()V (MinecraftServer.java:728) at net.minecraft.server.dedicated.DedicatedServer.func_71190_q()V (DedicatedServer.java:397) at net.minecraft.server.MinecraftServer.func_71217_p()V (MinecraftServer.java:668) at net.minecraft.server.MinecraftServer.run()V (MinecraftServer.java:526) at java.lang.Thread.run()V (Thread.java:748) ``` # Versions Forge Version: forge-1.12.2-14.23.5.2838-universal Mod Version: Geolosys-1.12.2-2.2.6 # Other Mods https://www.curseforge.com/minecraft/modpacks/sevtech-ages/relations/dependencies
import_user_oitsjustjose_95mQ commented 2020-07-04 14:23:15 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

assigned to @oitsjustjose

assigned to `@oitsjustjose`
import_user_oitsjustjose_95mQ commented 2020-07-04 14:27:21 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

I believe this issue has already been solved in newer versions - you're on a release from over a year ago. Have you tried updating to the latest release?

I believe this issue has already been solved in newer versions - you're on a release from over a year ago. Have you tried updating to the latest release?
import_user_oitsjustjose_95mQ commented 2020-07-16 18:51:21 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

Ah, the modpack seems to be behind with the version. Unfortunately I can only update it on the server and there seems to be too many changes on the client side.

Ah, the modpack seems to be behind with the version. Unfortunately I can only update it on the server and there seems to be too many changes on the client side.
import_user_oitsjustjose_95mQ commented 2020-07-16 18:52:32 +00:00 (Migrated from git.oitsjustjose.com)
Copy link

Alright then! I'll close this for now - but I'm sorry about your predicament 😔

Alright then! I'll close this for now - but I'm sorry about your predicament 😔
import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this issue 2020-07-16 18:52:32 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
1.20.1
1.21.1
1.12.x
1.18
1.19
1.16
1.15
1.14.x
1.12.x-UBC
No results found.
Labels
Clear labels   
bug

   
can't replicate

   
enhancement

   
help wanted

   
inter-mod

   
invalid

   
invasive

   
investigating

   
optimization
No labels
bug
can't replicate
enhancement
help wanted
inter-mod
invalid
invasive
investigating
optimization
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
oitsjustjose/Geolosys#245
No description provided.