[Ruby] Just a few concerns #9

New issue

Closed

opened 2018-04-16 16:41:35 +00:00 by import_user_oitsjustjose_95mQ · 2 comments

import_user_oitsjustjose_95mQ commented

2018-04-16 16:41:35 +00:00

(Migrated from git.oitsjustjose.com)

So, Josh pointed out a few valuable issues that I had missed in my Python code. As such, I had to update instructions.txt to make sure it drew the shape I wanted - but I noticed that the Ruby version had a few issues.

a. Draw Diagonal doesn't seem quite right, they're too far apart (I had this issue in Python too, but I have no clue how to fix this in Ruby)

b. The draw_empty_box doesn't seem to be drawing

Sorry that I had to change the instructions file AGAIN, that was totally my bad.

So, Josh pointed out a few valuable issues that I had missed in my Python code. As such, I had to update `instructions.txt` to make sure it drew the shape I wanted - but I noticed that the Ruby version had a few issues. a. Draw Diagonal doesn't seem quite right, they're too far apart (I had this issue in Python too, but I have no clue how to fix this in Ruby) b. The draw_empty_box doesn't seem to be drawing Sorry that I had to change the instructions file AGAIN, that was totally my bad.

import_user_oitsjustjose_95mQ commented

2018-04-18 02:20:55 +00:00

(Migrated from git.oitsjustjose.com)

Thanks for checking Jose!

I ran the ruby output against the python output and compared via difftool and they are identical. Not sure whats going on there, font issue? local ruby version??

I added the draw empty box, and fixed up my diagonals again.

Thanks man.

Thanks for checking Jose! I ran the ruby output against the python output and compared via difftool and they are identical. Not sure whats going on there, font issue? local ruby version?? I added the draw empty box, and fixed up my diagonals again. Thanks man.

import_user_oitsjustjose_95mQ (Migrated from git.oitsjustjose.com) closed this issue

2018-04-18 02:20:55 +00:00

import_user_oitsjustjose_95mQ commented

2018-04-18 02:21:36 +00:00

(Migrated from git.oitsjustjose.com)

❤️ Thank you for all your work! See discord for a message I'm about to send 😄

:heart: Thank you for all your work! See discord for a message I'm about to send :smile: